Always add adapter features into context #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the adapters replace a few features if endpoint metadata is configured for this to happen. However, this was intended to gate "expensive" operations, such as prebuffering the stream to enable InputStream. However, this now prevents APIs that are not "expensive" to be gated as well but are implemented in the feature as well. Some examples of this are `HttpRequest.End()` that is commonly used - it makes sense to implement it at the features, but shouldn't require buffering the response to turn it on. This change will still keep the gating in place for the "expensive" operations, but enable APIs that are provided by the features to be available if possible without the endpoint metadata.
twsouthwick
force-pushed
the
tasou/feature-refactor
branch
from
35d4ecf to
5bdf049
Compare
Tratcher
reviewed
Feb 17, 2023
src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/RegisterAdapterFeaturesMiddleware.cs
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the adapters replace a few features if endpoint metadata is configured for this to happen. However, this was intended to gate "expensive" operations, such as prebuffering the stream to enable InputStream. However, this now prevents APIs that are not "expensive" to be gated as well but are implemented in the feature as well. Some examples of this are
HttpRequest.End()that is commonly used - it makes sense to implement it at the features, but shouldn't require buffering the response to turn it on.This change will still keep the gating in place for the "expensive" operations, but enable APIs that are provided by the features to be available if possible without the endpoint metadata. It also adds some E2E tests using TestHost to verify these APIs perform as expected in the pipeline.