add support for context.SetSessionStateBehavior #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
requested changes
Sep 6, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/Internal/SessionStateFeature.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/SessionMiddleware.cs
Outdated
Show resolved
Hide resolved
|
@Clounea Thanks for working on this. I've looked into the question you had about the exception and it appears to have been caused by trying to commit a readonly session. I've fixed that. I've also pushed a few changes to clean up the tests to use xunit theories, as well as integrating in some changes from main that affect how we're structuring features. |
twsouthwick
reviewed
Oct 11, 2023
| @@ -2,13 +2,51 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| using System; | |||
| using System.Web.SessionState; | |||
|
|
|||
| namespace Microsoft.AspNetCore.SystemWebAdapters; | |||
|
|
|||
| [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method)] | |||
| public sealed class SessionAttribute : Attribute | |||
There was a problem hiding this comment.
@Clounea could you add some tests for this? other than that, I'm good with these changes
There was a problem hiding this comment.
Yes, I could. I will also add tests for overriding scenario
twsouthwick
requested changes
Oct 13, 2023
...soft.AspNetCore.SystemWebAdapters.CoreServices.Tests/SessionState/SessionIntegrationTests.cs
Outdated
Show resolved
Hide resolved
...soft.AspNetCore.SystemWebAdapters.CoreServices.Tests/SessionState/SessionIntegrationTests.cs
Outdated
Show resolved
Hide resolved
...soft.AspNetCore.SystemWebAdapters.CoreServices.Tests/SessionState/SessionIntegrationTests.cs
Outdated
Show resolved
Hide resolved
twsouthwick
reviewed
Oct 16, 2023
...soft.AspNetCore.SystemWebAdapters.CoreServices.Tests/SessionState/SessionIntegrationTests.cs
Outdated
Show resolved
Hide resolved
…/SessionState/SessionIntegrationTests.cs
twsouthwick
approved these changes
Oct 16, 2023
|
@Clounea LGTM! Thanks for iterating on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #371
I don't know if I could change the metadata. Comments are welcome.
And I don't find a good place to add tests. It seems that I need a web app and a beginrequesthandler where I could setsessionstatebehavior.