Prefer IHttpContextAccessor over HttpContextAccessor #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will check if we're currently in a runtime environment that contains a IHttpContextAccessor; if we are, then we'll prefer that over HttpContextAccessor. This allows people to potentially customize what it means to get and set a HttpContext.
|
@joperezr can you approve this? sharepoint needs to be able to use a custom IHttpContextAccessor |
Clounea
approved these changes
Jan 17, 2024
joperezr
reviewed
Jan 17, 2024
| using Microsoft.Extensions.Options; | ||
|
|
||
| namespace System.Web.Hosting; | ||
|
|
||
| internal sealed class HostingEnvironmentAccessor | ||
| { | ||
| private static readonly HttpContextAccessor _defaultHttpContextAccessor = new(); |
There was a problem hiding this comment.
I'm not very familiar with this code, but how often is _accessor or _current null? If not too often, should we make this be lazily evaluated instead so as to only initialize it if needed? (might also not matter if instantiating an HttpContextAccessor is cheap)
There was a problem hiding this comment.
how often is _accessor or _current null
good point - most of the time they are not null. It will only be if someone is running outside of a asp.net core host. I've changed it to just be a back up.
joperezr
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will check if we're currently in a runtime environment that contains a IHttpContextAccessor; if we are, then we'll prefer that over HttpContextAccessor. This allows people to potentially customize what it means to get and set a HttpContext.