Update samples #530
Merged
Update samples #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does the following: - Create a .slnLaunch file to easily launch the samples (including the multi-app samples) - Update YARP to 2.1.0 - Clean up registrations to recommended patterns - Convert samples to use MSBuild.SDK.SystemWeb
|
@joperezr can I get a review of this? |
4 tasks
joperezr
reviewed
Sep 6, 2024
| @@ -18,6 +18,7 @@ | |||
| } | |||
| }, | |||
| "msbuild-sdks": { | |||
| "MSBuild.SDK.SystemWeb": "4.0.88", | |||
There was a problem hiding this comment.
How will this get updated when new versions are available? Do we care at all?
There was a problem hiding this comment.
Not sure - probably manually until dependabot can handle global.json
joperezr
approved these changes
Sep 6, 2024
joperezr
reviewed
Sep 6, 2024
|
|
||
| <PropertyGroup> | ||
| <NoWarn> | ||
| $(NoWarn); |
There was a problem hiding this comment.
NIT: typically you would instead create an .editorconfig or .ruleset where you define which warnings should trigger.
There was a problem hiding this comment.
I agree, but with this it was quick and dirty to remove warnings and I'll follow up with a proper fix to the code patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following: