Add template deduction guide for Slice constructor #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @anforowicz |
JonathonReinhart
force-pushed
the
add-Slice-ctor-deduction-guide
branch
from
069b1ba to
a2d7e2b
Compare
anforowicz
reviewed
Feb 27, 2025
dtolnay
requested changes
Feb 27, 2025
JonathonReinhart
force-pushed
the
add-Slice-ctor-deduction-guide
branch
3 times, most recently
from
f846bb6 to
8eed1f7
Compare
PR dtolnay#1367 added an explicit Slice constructor which allows constructing from any C++ container. This adds a template deduction guide for that constructor which allows the Slice type to be inferred from the container's contained type, taking into account the const-ness of the type pointed to by data(). This applies only to C++17 and newer. Test: cargo test Test: cargo test -F c++14 Test: cargo test -F c++17 Test: cargo test -F c++20
JonathonReinhart
force-pushed
the
add-Slice-ctor-deduction-guide
branch
from
8eed1f7 to
33f3fa8
Compare
|
Published in cxx 1.0.142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1367 added an explicit Slice constructor which allows constructing from any C++ container.
This adds a C++17 template deduction guide for that constructor which allows the Slice type to be inferred from the container's contained type.
So instead of this:
One could write this, omitting the
rust::Slicetemplate arguments: