Add CICD workflow for generated files #752
Conversation
jakubno
force-pushed
the
setup-cicd-for-generated-files-e2b-2305
branch
2 times, most recently
from
ed180fa to
cb51db9
Compare
jakubno
force-pushed
the
setup-cicd-for-generated-files-e2b-2305
branch
from
33e457e to
a93848e
Compare
| go install google.golang.org/protobuf/cmd/protoc-gen-go@v${PROTOC_GEN_GO_VER} | ||
|
|
||
| # Install protoc-gen-go-grpc | ||
| go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v${PROTOC_GEN_GO_GRPC_VER} | ||
|
|
||
| # Install protoc-gen-connect-go | ||
| go install connectrpc.com/connect/cmd/protoc-gen-connect-go@${PROTOC_GEN_CONNECT_GO_VER} |
There was a problem hiding this comment.
All of these should be installed as tools, do we need to install them manually?
There was a problem hiding this comment.
it's used in this command
@protoc --go_out=../shared/pkg/grpc/orchestrator/ --go_opt=paths=source_relative --go-grpc_out=../shared/pkg/grpc/orchestrator/ --go-grpc_opt=paths=source_relative orchestrator.proto
and I didn't find protoc would support go tools (yet?)
There was a problem hiding this comment.
I think protoc doesn't, but the cmds somehow might. If not at all, I would move all of this to a Docker container, so we have parity between dev and this CI/CD
There was a problem hiding this comment.
I think @0div created a command that does the generation inside a Docker already.
There was a problem hiding this comment.
I'm not sure, but I think it was in the SDKs only
There was a problem hiding this comment.
(yes, the Docker is SDK only)
|
I left a comment, but otherwise looks good. |
Description
Check if all generated files are up today