Skip to content

Object.dirname is deprecated. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joewiz opened this issue Jan 22, 2018 · 2 comments
Closed

Object.dirname is deprecated. #27

joewiz opened this issue Jan 22, 2018 · 2 comments
Labels

Comments

@joewiz
Copy link
Member

joewiz commented Jan 22, 2018

Flagged by atom's Deprecation Cop:

Argument to path.dirname must be a string

Object.dirname (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:9:10)
Object.getCollectionPaths (/Users/joe/workspace/atom-existdb/lib/util.coffee:163:27)
Object.run (/Users/joe/workspace/atom-existdb/lib/existdb.coffee:186:30)
HTMLElement.subscriptions.add.atom.commands.add.existdb:run (/Users/joe/workspace/atom-existdb/lib/existdb.coffee:73:26)
CommandRegistry.handleCommandEvent (<embedded>:23521:36)
CommandRegistry.dispatch (<embedded>:23406:23)
@duncdrum duncdrum mentioned this issue Dec 3, 2018
@duncdrum
Copy link
Contributor

duncdrum commented Dec 3, 2018

the problem seems to lie here

@wolfgangmm with this line changed to:

@globalConfigPath = _path.join(_path.dirname(atom.config.getUserConfigPath.toString()), 'existdb.json')

i can get rid of the warnings about deprecated dirname calls, however, i still can't access the existdb.json file (no .?) that is part of my global config (the file is there) so something else is going on.

Maybe it would make more sense to change class ProjectConfig objects to by typed and have sensible defaults. as described here

The error i m seeing

screenshot 2018-12-03 at 16 00 37

@duncdrum
Copy link
Contributor

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants