Remove draft notation for map constructor entries

[joewiz]

What is the problem

The draft syntax for map entries is still supported in eXist, which allows users to write bad code.

A major version such as 5.0 would be a good opportunity to remove this syntax—just as we removed other draft-era functions like map:new.

What did you expect

Map constructor entry syntax is as follows: https://www.w3.org/TR/xquery-31/#prod-xquery31-MapConstructorEntry

However, according to http://exist-db.org/exist/apps/doc/xquery#legacy-features:

Map notation: During the drafting of XQuery 3.0, the specification changed slightly and so did the implementation in eXist-db. To keep backwards compatibility, eXist allows the older notation in map constructors: key:=value in addition to the new one, key: value.

Describe how to reproduce or add a test

Code such as map { "name" := "joe" } should raise an error.

Context information

• eXist-db version: current 4.x and 5.x
• Java version: n/a
• Operating system: n/a
• 32 or 64 bit: n/a
• How is eXist-db installed? n/a
• Any custom changes in e.g. conf.xml: n/a

[adamretter]

@joewiz Seems like a good idea to me

[joewiz]

As @duncdrum mentioned during the Community Call, this PR would require a new release of shared-resources, since the HTML templating module contains one use of the old syntax: https://github.com/eXist-db/shared-resources/blob/master/content/templates.xql#L94-L97.

Also, many HTML templating apps' view.xql files would need to be updated, e.g., https://gitlab.existsolutions.com/tei-publisher/tei-publisher-app/blob/master/modules/view.xql#L26-29.

[duncdrum]

exide's app-generator uses the proper syntax since 2016, generator apps always used the correct syntax in view.xql.
I think this counts as sufficient time, for users to escape the tyranny of the defaults.
@wolfgangmm I would still prefer if we'd use this opportunity to decouple html-templating from shared resources, and turn it into its own library package.

[line-o]

@joewiz oh wow, this beauty is hiding in a lot more places than I thought.

[joewiz]

@line-o Sure is! The most common culprit is view.xql of HTML Templating apps. I wonder if @craigberry could figure out a way to extend his code audit script to find these. I used the regex map\s*\{[^\}]+?:= over all of the XQuery files stored on my system. There were some false positives, but on the whole, it helped.

[joewiz]

@line-o I've completed reviewing the 18 eXist-db organization repositories with a view.xql file https://github.com/search?utf8=%E2%9C%93&q=org%3AeXist-db+filename%3Aview.xql&ref=simplesearch.

I have not reviewed:

• eXistSolutions repositories (7): https://github.com/search?q=org%3AeXistSolutions+filename%3Aview.xql&type=Code
• All GitHub repositories (381): https://github.com/search?q=filename%3Aview.xql+%22templates%3ACONFIG_APP_ROOT%22&type=Code

Unfortunately, GitLab doesn't support searching by filename, but I've already submitted a PR for tei-publisher: https://gitlab.existsolutions.com/tei-publisher/tei-publisher-app/merge_requests/73.

[joewiz]

FYI, the previous behavior has been in place since this PR, which was released in eXist 2.2: #320.

[joewiz]

New releases of the following stock apps have been published to the public repo:

• dashboard v2.0.2
• shared-resources v0.8.4
• monex v2.0.3

The following apps have PRs that need to be merged before a release can be cut:

• eXide (actually an xqlint issue) - Fix map constructor syntax wolfgangmm/xqlint#2
• documentation - Fix map constructor syntax documentation#365
• fundocs - Fix map constructor syntax function-documentation#32 (also related Align with monex's travis configuration function-documentation#33)

No changes to packageservice, functx, or markdown were needed.

I published new releases of the following non-core apps:

• public repo v0.8.3
• demo v0.4.3
• xsltforms-demo v0.1.5
• tei-pm v1.1.4

My PRs updating one other non-core app still needs review - and should be included in the next release of the app:

• TEI Publisher - https://gitlab.existsolutions.com/tei-publisher/tei-publisher-app/merge_requests/73

[joewiz]

I've submitted PRs for the TEI Publisher showcase apps:

• Shakespeare - https://gitlab.existsolutions.com/tei-publisher/shakespeare-pm4/merge_requests/1
• Van Gogh - https://gitlab.existsolutions.com/tei-publisher/vangogh/merge_requests/1
• EEBO - https://gitlab.existsolutions.com/tei-publisher/eebo-pm4/merge_requests/1

[joewiz]

Other repositories with the same PR that will need new releases:

• JFreeChart Fix map constructor syntax jfreechart#32
• Messaging & Replication Fix map constructor syntax messaging-replication#158
• Website Fix map constructor syntax website#21

I started a PR for AtomicWiki but then discovered it needed quite a bit more work to account for the removed functions. I pasted in the full audit, in case anyone is willing to complete the work:

• WIP: Prepare for eXist 5.x - removed functions and syntax AtomicWiki#64

[joewiz]

Thanks to help from @dizzzz, I've just released:

• Function Documentation v1.1.1
• JFreeChart v0.5.0

This leaves only:

• eXide - action @wolfgangmm for Fix map constructor syntax wolfgangmm/xqlint#2
• Messaging & Replication (which is not yet ready for a new release) - action @dizzzz
• Website - Fix map constructor syntax website#21
• AtomicWIki - WIP: Prepare for eXist 5.x - removed functions and syntax AtomicWiki#64
• TEI Publisher & apps based on it - see links above