Skip to content

objc: implement ability to create Protocols at runtime #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 8, 2025

Conversation

TotallyGamerJet
Copy link
Collaborator

@TotallyGamerJet TotallyGamerJet commented Jun 3, 2025

Allows creating protocols at runtime with an example program to dump protocol implementations

Closes #321

@hajimehoshi
Copy link
Member

Nice! As this seems an important change, can we file the issue first?

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests for the new functions?

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TotallyGamerJet
Copy link
Collaborator Author

TotallyGamerJet commented Jun 4, 2025

Do you want to wait to merge until Prummi can test it on Friday to make sure this actually resolves their issue?

@hajimehoshi
Copy link
Member

Do you want to wait to merge until Pummi can test it on Friday to make sure this actually resolves their issue?

If this is possible, yes!

@TotallyGamerJet
Copy link
Collaborator Author

@hajimehoshi Prummi said it solved their issue still good to merge?

@hajimehoshi
Copy link
Member

@hajimehoshi Prummi said it solved their issue still good to merge?

Yes!

@TotallyGamerJet TotallyGamerJet merged commit 1a51bed into ebitengine:main Jun 8, 2025
28 checks passed
@TotallyGamerJet TotallyGamerJet deleted the protocol branch June 8, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to implement objc Protocols
2 participants