[surround]: Visual mode surround issues

[rbhanot4739]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.surround

Question

Hi there !!

I came up with the following autocmd(with some assistance from copilot 😀) to move to the line where I start the visual selection, however with this in place when I visually select and do sa to add the surrounding, it does not work and simply wraps the line with ` character and then indents the selected line.

local function send_keys(keys)
  return vim.api.nvim_feedkeys(vim.api.nvim_replace_termcodes(keys, true, true, true), "n", false)
end

vim.api.nvim_create_autocmd("ModeChanged", {
  group = visual_mode_group,
  pattern = { "v:n", "V:n"}, -- Use raw escape code for ^V
  callback = function()
    vim.schedule(function()
      -- exit if we are not in normal
      if vim.fn.mode() ~= "n" then
        return
      end

      local up_end = vim.fn.line("'<")
      local down_end = vim.fn.line("'>")
      local curr = vim.fn.line(".")

      if curr == up_end then
        send_keys("`>")
      elseif curr == down_end then
        send_keys("`<")
      end
    end)
  end,
}

I do understand this isn't mini.surround issue and definitly skill issue on my end on not being able to fix this, so just looking for some help here.

[echasnovski]

... however with this in place when I visually select and do sa to add the surrounding, it does not work and simply wraps the line with ` character and then indents the selected line. ...

Yes, because there is an explicit send_keys("`>") which gets executed after pressing sa (as it internally leads to the mode change). As 'mini.surround' expects after sa a surrounding identifier, it treats ` (first key of send_keys()) as such identifier and surrounds selection with it.

I came up with the following autocmd(with some assistance from copilot 😀) to move to the line where I start the visual selection, ...

I don't really understand the use case here. With visual selection cursor can be either at start or end of visual selection. You can navigate between them with :h v_o and/or :h v_O. So to go to the selection start press o or O if cursor is at the other end and escape Visual mode as planned.

---

Anyway, this is indeed not a 'mini.surround' issue as it works as expected here.