Implement the health check service of the TSP #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the checkHealth method to request server's health status Signed-off-by: Geneviève Bastien <[email protected]>
|
Requires this patch for the trace server: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/174907 |
ghost
reviewed
Jan 22, 2021
| /** | ||
| * The server status | ||
| */ | ||
| status: 'UP' | 'DOWN'; |
There was a problem hiding this comment.
Trying to understand. Why not a simple boolean?
There was a problem hiding this comment.
Also, is it possible for the server to be down and still answer DOWN ?
There was a problem hiding this comment.
That's from the TSP. We may want to add more status eventually, like OVERLOADED!
And yes, a server that may offer many services could say, "no, I don't answer to trace queries right now". Not the current implementation, but some implementation may.
|
Maybe for later, add server metrics, like heap and whatnot. maybe it can be done via prometheus? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the checkHealth method to request server's health status
Signed-off-by: Geneviève Bastien [email protected]