Skip to content

Copy replacing does not correctly maintain areas #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oxdeception opened this issue Jun 22, 2021 · 2 comments
Closed

Copy replacing does not correctly maintain areas #974

Oxdeception opened this issue Jun 22, 2021 · 2 comments
Assignees
@ap891843
Labels
bug Something isn't working

Comments

@Oxdeception
Copy link

Description

When using a copy replacing statement for a copybook that has comment area numbering, the comment area is shifted into area B if the replaced text is longer than the replacing text. Errors also occur when the replacing text would make the line too long.

Expected behavior

Comment and sequence area characters are not moved by the copy statement, line continuations are used when needed.

Screenshots

image
image

Environment

  • OS: Windows 10, Manjaro Linux
  • IDE: VS Code

Additional information

The COBOL compiler will add spaces and line continuations when needed to ensure that copied text remains in the correct area.
@Oxdeception Oxdeception added the bug Something isn't working label Jun 22, 2021
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jun 25, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
dc2a0b2 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jun 25, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
43faf82 
Signed-off-by: ap891843 <[email protected]>
@temanbrcom temanbrcom linked a pull request Jun 25, 2021 that will close this issue
fix: maintain area for replacing service #988
Closed
@temanbrcom
Copy link
Contributor

Thank you for the reporting!
The fix will appear in the next release.

@ap891843
Copy link
Contributor

PR raised

ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jun 25, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
2edaa91 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 19, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
ed746e3 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 19, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
d3de827 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 20, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
22204c4 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 20, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
333ed21 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 20, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
6b58c46 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 20, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
a1bc041 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 21, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
57c926b 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 21, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
9b6c2e7 
Signed-off-by: ap891843 <[email protected]>
ap891843 added a commit to ap891843/che-che4z-lsp-for-cobol that referenced this issue Jul 21, 2021
@ap891843
fix: Maintain string length while replacing eclipse-che4z#974
4d2ae8b 
Signed-off-by: ap891843 <[email protected]>
temanbrcom added a commit that referenced this issue Jul 21, 2021
@temanbrcom
Merge pull request #1024 from ap891843/bugfix/replaceServiceBug
cb42266 
fix: Maintain string length while replacing #974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ap891843 ap891843

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: maintain area for replacing service ap891843/che-che4z-lsp-for-cobol
3 participants
@Oxdeception @temanbrcom @ap891843