Make Preprocessor Parts Stateless to Simplify DI #24 #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temanbrcom
changed the title
temanbrcom
changed the title
zacanbrcom
reviewed
Jan 27, 2020
| CobolLineReaderImpl reader = new CobolLineReaderImpl(null); | ||
| return reader.processLines(text, FIXED); | ||
| CobolLineReaderImpl reader = new CobolLineReaderImpl(); | ||
| return reader.processLines(null, text, FIXED); |
There was a problem hiding this comment.
I think we should plan a small effort to have an method overloading here instead to pass null
There was a problem hiding this comment.
Yes, work in progress
zacanbrcom
approved these changes
Jan 27, 2020
|
🎉 This PR is included in version 0.11.1-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.