Skip to content

feat: remove optional dot for file description entry clauses #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented May 24, 2024

as per the doc - https://www.ibm.com/docs/en/cobol-zos/6.4?topic=division-data-file-description-entries the file description entires can not have optional dots in between.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Following issue should be resolved
    image

wrong code

       IDENTIFICATION DIVISION.
       PROGRAM-ID. test23.
       ENVIRONMENT DIVISION.
       CONFIGURATION SECTION.
       SPECIAL-NAMES.
       INPUT-OUTPUT SECTION.
       FILE-CONTROL.
           select CARD_ABC ASSIGN to abc.
       DATA DIVISION.
        FILE SECTION.
         FD CARD_ABC
           record contains 0 CHARACTERS.
           BLOCK CONTAINS 0 RECORDS
           LABEL RECORDS are OMITTED.
       01 CARD_ABC_FIELD.
           05 A-FIELD pic x(9).
        WORKING-STORAGE SECTION.
        LINKAGE SECTION.
       PROCEDURE DIVISION.

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 requested a review from ishche May 24, 2024 14:54
@ap891843 ap891843 marked this pull request as draft May 27, 2024 07:56
@ap891843 ap891843 force-pushed the fix/fd-grammar-issue branch from 3906faa to dec13fb Compare May 27, 2024 08:25
@ap891843 ap891843 marked this pull request as ready for review May 27, 2024 08:26
@@ -417,7 +417,7 @@ fileDescriptionEntry
;

fileDescriptionEntryClauses
: (FD | SD) cobolWord (DOT_FS? fileDescriptionEntryClause)* dot_fs ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the doc - https://www.ibm.com/docs/en/cobol-zos/6.4?topic=division-data-file-description-entries
the file description entries can not have optional dots in between.

Signed-off-by: Aman Prashant <[email protected]>
@ap891843 ap891843 force-pushed the fix/fd-grammar-issue branch from dec13fb to 065164a Compare May 30, 2024 10:39
@ap891843 ap891843 requested a review from ishche May 30, 2024 14:28
@ishche ishche merged commit 2398ae3 into eclipse-che4z:development May 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants