Skip to content

fix: add language element to the cli analysis response in case of crash #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented Jul 1, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • cli response in case of crash includes language parameter

When the crash entry is written the details about the language id (cobol vs expcobol) are not captured.

file:/test-source/COBOL85/COBPGM/negative/NC1074.2.cbl,2024-06-28 17:42:04.938657,,,,0,"Cannot invoke ""org.antlr.v4.runtime.Token.getLine()"" because ""end"" is null"

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 requested a review from ishche July 1, 2024 12:57
@@ -70,6 +68,7 @@ public Integer call() throws Exception {
cliClientProvider.setCpyExt(createCopybooksExtensions());
JsonObject result = new JsonObject();
result.addProperty("uri", src.toURI().toString());
result.addProperty("language", dialect.getId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably now you can remove it from line 85

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@ap891843 ap891843 force-pushed the fix/cli_analysis_crash_response branch from e42d403 to 5b74a25 Compare July 1, 2024 14:36
@ap891843 ap891843 merged commit 1f87a10 into eclipse-che4z:development Jul 1, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants