Skip to content

fix: daco dot handling #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: daco dot handling #2445

merged 1 commit into from
Aug 23, 2024

Conversation

ishche
Copy link
Contributor

@ishche ishche commented Aug 22, 2024

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ishche ishche requested a review from slavek-kucera August 22, 2024 16:03
@ishche ishche mentioned this pull request Aug 23, 2024
Closed
slavek-kucera
slavek-kucera approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@slavek-kucera slavek-kucera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest revisiting this in the context of the range inclusive/exclusive end in the extendedtextline.

@ishche
Copy link
Contributor Author

ishche commented Aug 23, 2024 •
edited
Loading

I suggest revisiting this in the context of the range inclusive/exclusive end in the extendedtextline.

#2446 got an issue for it

@ishche ishche merged commit 7f2af07 into development Aug 23, 2024
16 of 17 checks passed
@ishche ishche deleted the daco-test-fix branch August 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavek-kucera slavek-kucera slavek-kucera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishche @slavek-kucera