-
Notifications
You must be signed in to change notification settings - Fork 62
feat: bridge for git initial support #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a50a5ca
to
8176a45
Compare
clients/cobol-lsp-vscode-extension/src/services/BridgeForGit.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/BridgeForGit.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/ProcessorGroups.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/ProcessorGroups.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/ProcessorGroups.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/ProcessorGroups.ts
Outdated
Show resolved
Hide resolved
82e3ffe
to
c0cd349
Compare
import * as t from "io-ts"; | ||
import { isLeft } from "fp-ts/Either"; | ||
import { PathReporter } from "io-ts/PathReporter"; | ||
import path = require("path"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, prefer VS code APIs which are universal across all environments instead of node specific APIs.
Typical example node:fs
=> vscode.workspace.fs
and node:path
=> vscode.Uri
.
clients/cobol-lsp-vscode-extension/src/services/ProcessorGroups.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/ProcessorGroups.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/BridgeForGit.ts
Outdated
Show resolved
Hide resolved
if (pgCfg === undefined) { | ||
return configObject; | ||
} | ||
const dialects: Preprocessor[] = []; | ||
if (!Array.isArray(pgCfg.preprocessor)) { | ||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pgCfg.preprocessor
in the else branch may be undefined.
if (typeof pgCfg.preprocessor === "string") {
dialects.push(pgCfg.preprocessor);
}
else if (Array.isArray(pgCfg.preprocessor)) {
for (const pp of pgCfg.preprocessor) {
if (typeof pp === "object" && pp && "name" in pp) {
dialects.push(pp.name);
}
else if (typeof pp === "string") {
dialects.push(pp);
}
}
}
else if (pgCfg.preprocessor && typeof pgCfg.preprocessor === "object" && "name" in pgCfg.preprocessor) {
dialects.push(pgCfg.preprocessor.name);
}
896da3f
to
6beb43a
Compare
Checklist: