Fix http connection #156
Merged
Fix http connection #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincenzo Territo <[email protected]>
Signed-off-by: Vincenzo Territo <[email protected]>
|
Hi @IrishWhiskey, thank you very much for your PR. I'll have a look at it and get back to you (sorry for taking so long). |
|
Hi @IrishWhiskey, your changes look very good. I'm just additionally adapting the |
|
@IrishWhiskey, can you verify if the rest implementation still works on your side? |
|
Hi @ffendt. It works for me. Thanks for helping me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the rest implementation bug discussed in #155