Skip to content

Make use of the new alwaysIProfileDuringStartupPhase option #18352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rmnattas
Copy link
Contributor

@rmnattas rmnattas commented Oct 26, 2023

Make use of the new alwaysIProfileDuringStartupPhase option instead of the TR_DisableNoIProfilerDuringStartupPhase environment variable in deciding whether we kick-in the IProfiler during the startup phase or not.

Depends on eclipse-omr/omr#7157

@rmnattas rmnattas marked this pull request as draft October 26, 2023 14:42
@rmnattas rmnattas force-pushed the alwaysProfileOption branch from 451a86e to 2a38e37 Compare October 26, 2023 23:33
@rmnattas rmnattas force-pushed the alwaysProfileOption branch from 2a38e37 to 9578f65 Compare October 26, 2023 23:34
@rmnattas rmnattas marked this pull request as ready for review October 26, 2023 23:46
@mpirvu mpirvu self-assigned this Oct 27, 2023
@mpirvu mpirvu added comp:jit depends:omr Pull request is dependent on a corresponding change in OMR labels Oct 27, 2023
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmnattas rmnattas changed the title Make use of the new alwaysProfileDuringStartup option Make use of the new alwaysIProfileDuringStartupPhase option Oct 27, 2023
@mpirvu
Copy link
Contributor

mpirvu commented Oct 27, 2023

jenkins test sanity zlinuxjit jdk17 depends eclipse-omr/omr#7157

@rmnattas rmnattas marked this pull request as draft October 31, 2023 13:18
@rmnattas
Copy link
Contributor Author

Going with #18381 instead.

@rmnattas rmnattas closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants