CRIU adds unqualified exports java.base/jdk.crac when CRaC is enabled #18959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
reviewed
Feb 20, 2024
JasonFengJ9
force-pushed
the
addexports
branch
from
d661e5e to
3d4bde8
Compare
|
@JasonFengJ9 I think you'll need to rebase, we got rid of the static initializer code in InterCRIUSupport, it was causing bootstrap issues with MH |
JasonFengJ9
force-pushed
the
addexports
branch
from
3d4bde8 to
001af11
Compare
Rebased, moved |
tajila
reviewed
Feb 21, 2024
tajila
approved these changes
Feb 21, 2024
|
jenkins test sanity alinux jdk11 |
|
jenkinst test sanity plinux jdk21 |
Use Module.implAddExports("jdk.crac") to export
java.base/jdk.crac unconditionally when the CRaC is enabled;
Refactored throwExceptionHelper(currentThread, errCode);
Also fixed addPackageDefinition() usage in JVM_AddModulePackage().
Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
addexports
branch
from
001af11 to
ee82cd8
Compare
|
Rebased and resolved the conflict. |
tajila
reviewed
Feb 22, 2024
tajila
approved these changes
Feb 23, 2024
|
jenkins test sanity win jdk8 |
|
jenkins test sanity plinux jdk21 |
It seems an infra error. |
|
It's #18998 |
keithc-ca
reviewed
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIUadds unqualifiedexportsjava.base/jdk.cracwhenCRaCis enabledUse
Module.implAddExports("jdk.crac")to exportjava.base/jdk.cracunconditionally when theCRaCis enabled;Refactored
throwExceptionHelper(currentThread, errCode);Also fixed
addPackageDefinition()usage inJVM_AddModulePackage().Resolve RTC workitem 150440.
Signed-off-by: Jason Feng [email protected]