[FFI/v0.44] Enable heap related code in downcall #19008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2024 16:09
The changes aim to pass the heap arguments to native when the linker option intended for the critical downcall is specified. Note: The feature implemented in this PR is specified in JEP454/JDK22 at eclipse-openj9#17872 Signed-off-by: ChengJin01 <[email protected]>
The tiny changes modify the constant used to identify the heap address in downcall to avoid any potential conflict with the address value passed to downcall. Fixes: eclipse-openj9#18999 Signed-off-by: ChengJin01 <[email protected]>
|
jenkins line endings check |
pshipton
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes cherry-picks #18930 and #19002
specific to the passage of heap arguments to
downcall for 0.44.0-release.
Signed-off-by: ChengJin01 [email protected]