(0.44) Fix String creation to treat a modified UTF8 zero as ASCII #19293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates j9gc_createJavaLangString(). Issue eclipse-openj9#19273 Signed-off-by: Peter Shipton <[email protected]>
keithc-ca
reviewed
Apr 10, 2024
| /* test https://github.com/eclipse-openj9/openj9/issues/19273 */ | ||
| String s1 = "a"; | ||
| String s2 = "b"; | ||
| AssertJUnit.assertTrue("Incorrect index of \\u0000", (s1 + "\u0000" + s2).lastIndexOf("\u0000") == 1); |
There was a problem hiding this comment.
A more failure-friendly expression of this would have used assertEquals which reports both the actual and expected values. Perhaps you could fix this on the master branch?
keithc-ca
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates j9gc_createJavaLangString().
Issue #19273