(0.44) Use signed comparisons for Latin-1 encoded indexOf in VP #19444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementations of String.indexOf operations cast the target char to a byte if Latin-1 encoded Strings are involved. The value might be cast to type byte by the caller or in the implementation itself, depending on the JDK version. Value Propagation has to ensure that it uses signed byte comparisons if it transforms an indexOf involving a known String to replicate the run-time behaviour that otherwise would have resulted, regardless of JDK version.
|
@pshipton, may I ask you to merge this change to the v0.44.0-release branch? |
|
For some reason the link to the Line Endings Check appears to be for the bad pull request #19443 I had opened and closed just before I opened this one. The actual Line Endings Check for this pull request was successful. |
pshipton
changed the title
pshipton
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementations of String.indexOf operations cast the target char to a byte if Latin-1 encoded Strings are involved. The value might be cast to type byte by the caller or in the implementation itself, depending on the JDK version.
Value Propagation has to ensure that it uses signed byte comparisons if it transforms an indexOf involving a known String to replicate the run-time behaviour that otherwise would have resulted, regardless of JDK version.
Port of OpenJ9 pull request #19428 to v0.44.0-release branch.
Fixes: #18974