Remove withfield/aconst_init from ValueTypeTests #19770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
fix_18316_tests
branch
from
cbb9026 to
758cf99
Compare
theresa-m
added
comp:test
project:valhalla
hangshao0
reviewed
Jun 27, 2024
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
fix_18316_tests
branch
from
758cf99 to
f5a6460
Compare
theresa-m
force-pushed
the
fix_18316_tests
branch
3 times, most recently
from
c244a54 to
f454a84
Compare
|
Jenkins test sanity,extended zlinuxval jdknext |
|
Jenkins test sanity,extended amac jdk21 |
|
I will take a look at the extended failure. |
theresa-m
force-pushed
the
fix_18316_tests
branch
from
f454a84 to
1847ba6
Compare
- Remove ACONST_INIT and WITHFIELD bytecode uses from tests - Consolidate value and reference class generator creation methods now that both use <init> and putfield - Remove wither tests. There is no equivalent behavior in the new spec. - Remove testWithFieldOnNonValueType, testWithFieldOnNull, testWithFieldOnNonExistentClass, testUnresolvedWithFieldUse Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
fix_18316_tests
branch
from
1847ba6 to
1d44260
Compare
|
The tests should pass now. DDRValueTypeTest.java was using an outdated method name. |
|
Links of previous PR builds: |
|
Jenkins test sanity,extended zlinuxval jdknext |
hangshao0
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18316