Skip to content

Modify static assert to be C++11 conformant #19796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

cjjdespres
Copy link
Contributor

A static_assert declaration without a string literal message is only available in C++17. This causes a compilation error in clang, as the compiler is built with the C++11 standard.

A static_assert declaration without a string literal message is only
available in C++17. This causes a compilation error in clang, as the
compiler is built with the C++11 standard.

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres cjjdespres requested a review from dsouzai as a code owner July 3, 2024 15:42
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu mpirvu self-assigned this Jul 3, 2024
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Jul 3, 2024
@mpirvu
Copy link
Contributor

mpirvu commented Jul 3, 2024

jenkins compile xlinuxjit,zlinuxjit,alinux64jit jdk17

@mpirvu mpirvu merged commit 9cbb1d5 into eclipse-openj9:master Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants