Skip to content

Add support for aarch64 to j9vm.runner.Runner #19943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

keithc-ca
Copy link
Contributor

Also reorganize and tidy up.

This was motivated by messages like

[2024-07-26T07:59:06.968Z] Runner couldn't determine underlying architecture. Got OS Arch:aarch64

A recent example can be seen in a JDK acceptance build.

@keithc-ca keithc-ca requested a review from llxia July 30, 2024 18:27
@keithc-ca
Copy link
Contributor Author

Jenkins test sanity alinux,zlinux jdk21

@keithc-ca keithc-ca marked this pull request as draft July 30, 2024 21:12
Also reorganize and tidy up.

Fixed JavaHomeTestRunner which assumed that getCommandLine()
returns a string that ends with a space.

Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca
Copy link
Contributor Author

Update removed assumption in JavaHomeTestRunner that getCommandLine() returns a string that ends with a space.

@keithc-ca
Copy link
Contributor Author

Jenkins test sanity alinux,zlinux jdk21

@keithc-ca keithc-ca marked this pull request as ready for review July 31, 2024 12:23
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 0b32a25 into eclipse-openj9:master Aug 1, 2024
7 checks passed
@llxia llxia added the comp:test label Aug 1, 2024
@keithc-ca keithc-ca deleted the runner branch August 1, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants