Changes for new/delete used by IProfiler #19973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity all jdk21 |
2 similar comments
|
jenkins test sanity all jdk21 |
|
jenkins test sanity all jdk21 |
|
Testing continues to fail with: |
|
jenkins test sanity all jdk17 |
|
@dsouzai Could you please review/merge? Thanks |
dsouzai
approved these changes
Aug 9, 2024
|
@mpirvu build failure due to |
This commit implements the following changes: - `operator new` was defined in every class derived from TR_IPBytecodeHashTableEntry After this commit there will be only one definition of `operator new` provided by the base class TR_IPBytecodeHashTableEntry and all derived classes will use the same definition. The same applies for `operator delete` - `operator delete` used to do nothing. After this commit `operator delete` will use the IProfiler persistent memory deallocator to free memory. Note that freed memory goes into a pool, to be reused later. - For 64-bit environments, `operator new` used to ensure aligned allocations by adding four bytes the size needed and then rounding up on a 8 byte boundary. This is not needed, because the persistent allocator already makes sure that allocations are 8 byte aligned, so the operator was just wasting memory. - TR_IProfiler::findOrCreateEntry() contains a race condition which may lead to a small (and bounded) memory leak. This commit frees the entry that is allocated but later found that is not needed. Signed-off-by: Marius Pirvu <[email protected]>
|
jenkins test sanity amac jdk17 |
|
jenkins test sanity all jdk17 |
|
windows build failed with The error on zlinux is [testJitserverArguments_0] and has nothing to do with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the following changes:
operator newwas defined in every class derived from TR_IPBytecodeHashTableEntry After this commit there will be only one definition ofoperator newprovided by the base class TR_IPBytecodeHashTableEntry and all derived classes will use the same definition. The same applies foroperator deleteoperator deleteused to do nothing. After this commitoperator deletewill use the IProfiler persistent memory deallocator to free memory. Note that freed memory goes into a pool, to be reused later.operator newused to ensure aligned allocations by adding four bytes the size needed and then rounding up on a 8 byte boundary. This is not needed, because the persistent allocator already makes sure that allocations are 8 byte aligned, so the operator was just wasting memory.