Display ignored -Xjit and -Xaot args in IGNOREDARGS list #19990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpirvu
reviewed
Aug 13, 2024
|
@keithc-ca Could you please review this PR too since it modifies VM files? Thanks |
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
from
70f582b to
acb636d
Compare
mpirvu
approved these changes
Aug 13, 2024
keithc-ca
requested changes
Aug 13, 2024
There was a problem hiding this comment.
I think the code should be reorganized so ignored options are printed in the same order they're specified on the command line. I expect that means the first new loop must be inserted before the existing loop, and the work of the second new loop must be merged into the existing loop.
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
3 times, most recently
from
c8f4627 to
878b92d
Compare
keithc-ca
requested changes
Aug 14, 2024
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
from
878b92d to
e037d6b
Compare
keithc-ca
requested changes
Aug 15, 2024
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
from
e037d6b to
27e5685
Compare
|
All the comments should have been addressed now |
keithc-ca
requested changes
Aug 15, 2024
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
2 times, most recently
from
e68c926 to
ef53004
Compare
|
All the comments should have been addressed now |
keithc-ca
requested changes
Aug 15, 2024
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
from
ef53004 to
cfec721
Compare
|
Please address the failure of the line endings check. |
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
from
cfec721 to
2aa1b5f
Compare
|
Trailing whitespace removed |
luke-li-2003
force-pushed
the
DumpIgnoredArgs
branch
from
2aa1b5f to
ee032fc
Compare
|
Jenkins test sanity amac jdk17 |
keithc-ca
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-Xjitand-Xaotargs being ignored because there are multiple-Xjitor-Xaotarguments (only the last one will be considered), or because there exists-Xnojit,-Xnoaot, or-Xint(ignores the arguments before the in the command line option) will be displayed in the IGNOREDARGS list during the core dump.Fixes #19742