[FFI/Test] Fix the wrong invocation on the native function in downcall #20080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR resolves the test issue with the wrong invocation in downcall to ensure the test code in java calls the correct native function in native. Fixes: eclipse-openj9#20048 Signed-off-by: ChengJin01 <[email protected]>
ChengJin01
added
comp:test
project:panama
|
The test fix was verified on all supported platforms at #20048 (comment), which are simply changes from |
pshipton
approved these changes
Aug 29, 2024
|
I assume we need a PR created for 0.48 as well? |
ChengJin01
pushed a commit
to ChengJin01/openj9
that referenced
this pull request
Aug 29, 2024
The PR resolves the test issue with the wrong invocation in downcall to ensure the test code in java calls the correct native function in native. Cherry pick of eclipse-openj9#20080 for 0.48 Signed-off-by: ChengJin01 <[email protected]>
PR is created at #20082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR resolves the test issue with the wrong invocation in downcall
to ensure the test code in java calls the correct native function in
native.
Fixes: #20048
Signed-off-by: ChengJin01 [email protected]