(0.48) CRIU supports Java debugger via the restore option file #20191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugger support related code are guarded with isDebugOnRestoreEnabled(); For -Xint mode, do not disable JVMTI capabilities required for JDWP debugger before checkpoint, add a capability can_access_local_variables; For JIT mode, add JVMTI capabilities required for JDWP debugger before checkpoint; Hooked J9HOOK_VM_PREPARING_FOR_RESTORE event to determine if a JDWP agent is specified in the restore option file, also hooked J9HOOK_VM_CRIU_RESTORE to load the agent libraries; Support -agentlib/-agentpath and -Xrunjdwp; Refactored the agent library creation from J9VMInitArgs; Added some trace points; Disable criu_jitPostRestore.xml failure conditions until the JIT PR is merged. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
added this to the
Release 0.48 (Java 8, 11, 17, 21, 23) October refresh milestone
|
Ill merge after tonights builds |
This was referenced Oct 1, 2024
|
It seems last night's builds have no failure related to and it did resolve the failures reported in #20194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIU supports Java debugger via the restore option file
Debugger support related code are guarded with
isDebugOnRestoreEnabled();For
-Xintmode, do not disableJVMTIcapabilities required forJDWPdebugger before checkpoint, add a capabilitycan_access_local_variables;For
JITmode, addJVMTIcapabilities required forJDWPdebugger before checkpoint;Hooked
J9HOOK_VM_PREPARING_FOR_RESTOREevent to determine if aJDWPagent is specified in the restore option file, also hookedJ9HOOK_VM_CRIU_RESTOREto load the agent libraries;Refactored the agent library creation from
J9VMInitArgs;Added some trace points.
Cherry-pick
Signed-off-by: Jason Feng [email protected]