Add basic UI test with Spectron #371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Aug 4, 2017
| this.timeout(60000); | ||
|
|
||
| beforeEach(function () { | ||
| require("../src-gen/backend/main"); // start the express server |
There was a problem hiding this comment.
Should not it be done by electron-main and we only should wait until the window is visible?
There was a problem hiding this comment.
I tried to add waitUntilWindowLoaded(), but got an error:
return app.client.waitUntilWindowLoaded(10000)
TypeError: waitUntilWindowLoaded Cannot read property 'isLoading' of undefined
at waitUntil(<Function>, 60000) - application.js:227:17
error Command failed with exit code 1.
Looking at electron-userland/spectron#174, seems similar.
|
See #87 for the devtools issue |
|
can this be closed, because you mentioned yesterday you stop looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic UI test with Spectron.