-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Integration of allure report tool #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integration of allure report tool #1894
Conversation
…integration-allure-report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrYurk @rafaelmag110 sorry for interrupting this long discussion but wouldn't it be better to just have this merged and then update accordingly? this is not productive code and the impact of this is really low so I wouldn't waste too much time.
My 2 cents: @AndrYurk the comments @rafaelmag110 made are pretty similar to mine in my internal review, and if two committers have the same thoughts about that I don't see why just don't adapt and have this merged, you'll have the possibility to demonstrate that your approach is better once we have everything in place and we'll start to see some reports.
The release process will be changed in any case (see #1833) so let's do this incrementally.
@ndr-brt thanks for your feedback, actually it has been already adapted with the recommendations under the last commit few days ago. Or did I miss something? |
tbh it took me some time to read the comments and it looked like the discussion was still open, so I didn't went through the document. @rafaelmag110 feel free to approve and merge then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting there. Just a small nit and then i'm ready to merge it!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrYurk thanks for the patience!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
WHAT
This PR integrates the Allure reporting tool and GitHub workflow to publish test reports in the release notes.
WHY
To enhance transparency regarding the End-to-End tests executed during the release process.
Closes #1830