fix(config) - added missing opentelemetry options #1915
Conversation
…m default 9464 to 9090, and overriden exporter format
kkotowiczz
requested review from
rafaelmag110,
ndr-brt and
lgblaumeiser
as code owners
| @@ -333,6 +334,9 @@ controlplane: | |||
| opentelemetry: |- | |||
| otel.javaagent.enabled=false | |||
| otel.javaagent.debug=false | |||
| # By default prometheus uses port 9464 | |||
There was a problem hiding this comment.
One slight proposal on this comment and the same below, @kkotowiczz. I do not understand the point. Is it, that this config is only needed, because otel and prometheus are not aligned concerning port? Please adapt the comment in a way, that describes the issue better. Thanks!
There was a problem hiding this comment.
If it's just a configuration issue why is this change needed to happen here? tbh I don't see why we should have a particular exporter configured by default when that should be done by the user (in fact, the java agent is disabled by default, see line 335)
There was a problem hiding this comment.
Ok, so it seems then like #1905 it's not a bug, because these are the only changes needed to scrap metrics with prometheus.
So I don't know how you proceed in similar cases.
There was a problem hiding this comment.
Maybe we can just provide documentation to tell users how they can have the /metrics endpoint exposed
|
| @@ -333,6 +334,9 @@ controlplane: | |||
| opentelemetry: |- | |||
| otel.javaagent.enabled=false | |||
| otel.javaagent.debug=false | |||
| # By default prometheus uses port 9464 | |||
There was a problem hiding this comment.
If it's just a configuration issue why is this change needed to happen here? tbh I don't see why we should have a particular exporter configured by default when that should be done by the user (in fact, the java agent is disabled by default, see line 335)
|
@kkotowiczz the documentation could have been done in this PR :) |
WHAT
remapped port from default 9464 to 9090, and overriden exporter format
WHY
In order to be able to scrap metrics with prometheus, when otel javaagent is enabled
FURTHER NOTES
N/A
Closes #1905