-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: hostHeaders default value is empty string #5412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for the default value of config.hostHeaders, changing it from "x-forwarded-host" to an empty string. It also adds clarifications for reverse proxy deployments in both Chinese and English versions of the docs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
site/docs/basics/controller.zh-CN.md | Updated the default value documentation and added reverse proxy instructions. |
site/docs/basics/controller.md | Revised the default configuration details and provided further proxy configuration guidance. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5412 +/- ##
===========================================
+ Coverage 88.36% 99.69% +11.33%
===========================================
Files 39 35 -4
Lines 3772 3609 -163
Branches 342 538 +196
===========================================
+ Hits 3333 3598 +265
+ Misses 439 11 -428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pick from #5412 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated plugin links to reflect the current repository addresses. - Improved clarity on host header behavior and configuration, including guidance for reverse proxy setups. - Enhanced textual explanations for properties related to host and protocol. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
closes #5411