Download the media files via the browser download mechanism #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces the javascript download function for media files by the integrated browser download mechanism.
dennis531
added
type:bug
v:3
|
Die gesamte UI und Funktionalität einfach wieder zu entfernen scheint mir ziemlich rigoros. Wenn man sich um die Randfälle mit wenig Rechenleistung und RAM Sorgen macht, dann würde ich genau auf den Aspekt eingehen. Fetch im Stream Betrieb sollte mit Chunks und einem Blob am Ende deutlich effizienter sein. Das würde ich als ein ausgewogenen Kompromiss betrachten. Wenn wir an der Stelle noch mehr optimieren wollen, könnten wir eine Bibliothek wie StreamSaver.js in Kombination mit Fetch verwenden. Den Nutzenden kein Feedback bei zeitaufwendigen Downloads zu geben halte ich für nicht zeitgemäß. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the javascript download function for media files by the integrated browser download mechanism.
Fix #1383