Remove ignoreUrl file setting property #123718
Open
+13
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urls may make the FileAccessTree invalid. This commit removes the flag for filtering urls, instead always filtering them.
rjernst
added
>refactoring
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
reviewed
Feb 28, 2025
| if (ignoreUrl) { | ||
| result = result.filter(s -> s.toLowerCase(Locale.ROOT).startsWith("https://") == false); | ||
| } | ||
| result = result.filter(s -> s.toLowerCase(Locale.ROOT).startsWith("https://") == false); |
There was a problem hiding this comment.
We can't rely on all setting rejecting http, right? Shouldn't we make sure to exclude such urls as well, so we keep the filtetree clean?
ldematte
reviewed
Feb 28, 2025
| if (ignoreUrl) { | ||
| result = result.filter(s -> s.toLowerCase(Locale.ROOT).startsWith("https://") == false); | ||
| } | ||
| result = result.filter(s -> s.toLowerCase(Locale.ROOT).startsWith("https://") == false); |
There was a problem hiding this comment.
Should we ignore all URLs? http://, ftp:// (if we even allow that thing).
Even file:// if passed down to FileAccessTree as is would make a mess of the path sting.
|
I agree we should be filtering all urls, but identifying arbitrary urls becomes much more complex. Right now these settings only support https, and they fail otherwise. Can we leave that as a followup? This PR is removing the ignoreUrl property, not changing the behavior of how we ignore urls. |
ldematte
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urls may make the FileAccessTree invalid. This commit removes the flag for filtering urls, instead always filtering them.