-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[lens] Use top nav in Lens app #46190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
27b6824
[lens] Use top nav in Lens app
wylieconlon 9ace121
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 2c6817c
Add tests for saved query, pass filters around more places
wylieconlon d69977c
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon a787f94
Fix filter passing
wylieconlon cfd7b8b
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 761be14
Add unit test for field popover making correct queries
wylieconlon 9aad4b8
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 0bf1b44
Respond to review feedback
wylieconlon 588635e
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 3c02c20
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon c8361c9
Fix type errors
wylieconlon edd1628
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 124b1e9
Respond to all review comments
wylieconlon 29abf4c
Remove commented code
wylieconlon 9bc8214
Top nav should be compatible as angular directive
wylieconlon 0639138
Fix rendering issue with filter updates
wylieconlon 449155f
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 85c089a
Merge remote-tracking branch 'origin/master' into lens/use-top-nav
wylieconlon 3bf24ef
Respond to review comments and add onChange test
wylieconlon dcd2495
Add specific test for the index pattern bug from Tina
wylieconlon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
export function buildQueryFromFilters(filters: unknown[], indexPattern: unknown): unknown; | ||
export function buildEsQuery( | ||
indexPattern: unknown, | ||
queries: unknown, | ||
filters: unknown, | ||
config?: { | ||
allowLeadingWildcards: boolean; | ||
queryStringOptions: unknown; | ||
TinaHeiligers marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ignoreFilterIfFieldNotInIndex: boolean; | ||
dateFormatTZ?: string | null; | ||
} | ||
): unknown; | ||
export function getEsQueryConfig(config: { | ||
get: (name: string) => unknown; | ||
}): { | ||
allowLeadingWildcards: boolean; | ||
queryStringOptions: unknown; | ||
ignoreFilterIfFieldNotInIndex: boolean; | ||
dateFormatTZ?: string | null; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,5 +17,6 @@ | |
* under the License. | ||
*/ | ||
|
||
export * from './es_query'; | ||
export * from './kuery'; | ||
export * from './filters'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,6 @@ | |
} | ||
|
||
.lnsApp__header { | ||
padding: $euiSize; | ||
border-bottom: $euiBorderThin; | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.