-
Notifications
You must be signed in to change notification settings - Fork 26
Add log to dplyr function ungroup() #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Libraries are already present in main file testthat.R
I got error with ~. No errors using functions names directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a few comments. As you've suggested I'd prefer the ungroup
function be part of group_by
. (Same for the tests)
As for the tests files, I actually like having the library calls on top, because that makes debugging them easier. Could you revert? In general, also best to keep things in separate PRs, so it's easier to review :)
Also feel free to add a new bullet point in NEWS.md
.
DESCRIPTION
Outdated
@@ -1,9 +1,13 @@ | |||
Package: tidylog | |||
Type: Package | |||
Title: Logging for 'dplyr' and 'tidyr' Functions | |||
Title: Logging for 'dplyr' and 'tidyr' functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 3e70eea
DESCRIPTION
Outdated
person("Benjamin", "Elbers", email = "[email protected]", | ||
role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5392-3448")), | ||
person("Damiano", "Oldoni", email = "[email protected]", | ||
role = c("aut", "ctb"), comment = c(ORCID = "0000-0003-3445-7562")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use just "ctb" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very sorry: I am definitely not the author! A copy paste error.
Solved here: baae929
README.Rmd
Outdated
``` | ||
Here, it might have been accidental that the last `filter` command had no effect. | ||
Here, it might have been accidental that the `filter` command had no effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please leave as is, or change to "second"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right: it refers to the fact that there are two filters, indeed.
Solved here: 39c624f
A copy paste error, sorry @elbersb
Attempt to get codecov/patch passing (full coverage of group_by.R)
I think I solved all requested changes. Please, give a look again. Thanks. |
Thanks, that's great. If you'd like to have another go at this, feel free -- if not, I'll merge and then implement this. |
I like your idea. I gave it a try. Let me know. Thanks. |
Thanks! |
This PR aims to solve #32.
ungroup: no grouping variables left
.ungroup.R
added to./R
directory. Another way to work would be to add functionungroup()
in file./R/group_by.R
.test_ungroup.R
ungroup()
at the end of example about grouping.Travis says yes and pkg documentation seems ok 👍
Have a deep look and let me know. Especially point 2 seems something you, as maintainer, has the last word about.
Thanks for writing, updating and maintaining this wonderful package.