Skip to content

chore: migrate to fs/promises #5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

chore: migrate to fs/promises #5880

wants to merge 0 commits into from

Conversation

develar
Copy link
Member

@develar develar commented May 12, 2021

Avoid deprecation errors about using "rmdir".

@develar develar force-pushed the fs-promise branch 3 times, most recently from fdb456a to a54a1a3 Compare May 13, 2021 14:09
@mmaietta
Copy link
Collaborator

Hmmmm, a different 'targets' test is now failing and it isn't generating most of the expected artifacts

Snapshot name: `targets 1`

- Snapshot  - 16
+ Received  +  0

  Object {
    "linux": Array [
      Object {
        "arch": "x64",
-       "file": "TestApp-1.1.0.7z",
-     },
-     Object {
-       "arch": "x64",
-       "file": "TestApp-1.1.0.freebsd",
-     },
-     Object {
-       "arch": "x64",
        "file": "TestApp-1.1.0.pacman",
-     },
-     Object {
-       "arch": "x64",
-       "file": "TestApp-1.1.0.sh",
-     },
-     Object {
-       "arch": "x64",
-       "file": "TestApp-1.1.0.zip",
      },
    ],
  }
    at packAndCheck (/root/project/test/src/helpers/packTester.ts:244:27)

@develar develar closed this May 14, 2021
@develar develar deleted the fs-promise branch May 14, 2021 05:45
@kapalex
Copy link

kapalex commented May 23, 2021

Just letting you know this causes an issue with builds for node 13.x envionments (throw exception of cannot find module 'fs/promises')
For me I ran into this when trying to build on windows 7 where node 14 is not supported.

@bromix
Copy link

bromix commented Jun 11, 2021

Same here with Node 12.x

> PROJECTNAME postinstall C:\Development\ashampoo\connect\connect-launcher
> electron-builder install-app-deps

Error: Cannot find module 'fs/promises'

Now we are not able to create a production build for our new release :(

@Yongle-Fu
Copy link

Same here with Node 12.x

> PROJECTNAME postinstall C:\Development\ashampoo\connect\connect-launcher
> electron-builder install-app-deps

Error: Cannot find module 'fs/promises'

Now we are not able to create a production build for our new release :(

Same here with Node 12.x, fallback to 22.10.5 will be ok
#5953

@alectrocute
Copy link

alectrocute commented Jun 11, 2021

This broke our CI builds today on Node 12.x.

@nuochong
Copy link

me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants