Skip to content

Add RoomAndToDeviceKeyTransport #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Apr 11, 2025

Warning: This enables the to-device transport developer flag by default with the reasoning, that it will autmatically fallback to room events and hence is backwards compatible.

Needs thorough testing.

This replaces the current dev option of to-device key sharing with a different option that starts with toDevice but will fallback to room events once another member sends a room event.

@toger5 toger5 requested a review from a team as a code owner April 11, 2025 08:00
@toger5 toger5 requested review from AndrewFerr and removed request for a team April 11, 2025 08:00
@toger5 toger5 added the PR-Improvement Release note category. A PR that improves EC's performance or stability. label Apr 11, 2025
@toger5 toger5 requested a review from a team April 11, 2025 08:12
@toger5 toger5 force-pushed the toger5/test-with-room-and-to-device-transport branch from 0be3bf8 to 8c8a5e2 Compare April 11, 2025 14:44
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2025

CLA assistant check
All committers have signed the CLA.

@toger5 toger5 changed the base branch from toger5/test-with-to-device to livekit April 11, 2025 14:54
@toger5 toger5 force-pushed the toger5/test-with-room-and-to-device-transport branch from 9299136 to e0a5d89 Compare April 11, 2025 14:55
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@toger5 toger5 merged commit 770b94e into livekit Apr 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Improvement Release note category. A PR that improves EC's performance or stability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants