Skip to content

Demo/UtilsView: fix deprecation warnings #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danirabbit
Copy link
Member

Use Gtk.ColorDialog, add provider for display

@danirabbit danirabbit requested a review from a team March 20, 2025 20:12
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color dialog appears at (0, 0) of the screen rather then centered. Other than that looks good.

@danirabbit
Copy link
Member Author

Screenshot from 2025-03-27 10 45 17

@jeremypw can't confirm that. It appears centered on the window here. Are you still running OS 7? Maybe an OS 7 bug?

@jeremypw
Copy link
Contributor

@danirabbit It happens in Classic session but not in Secure session for me. However, I am running OS8 in a VM on OS7.1

@danirabbit
Copy link
Member Author

@jeremypw I can confirm the window is spawning at 0,0 in X11, but we're dimming the correct window so the parent is being set correctly here. There's nothing I can do to set the window position other than setting the parent. So this must be a bug somewhere else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants