Skip to content

UserRow: handle current user #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 4, 2025

Have UserRow handle the case where its user is the current user instead of duplicating all that code into another widget

@danirabbit danirabbit requested a review from a team March 4, 2025 05:22
@danirabbit danirabbit marked this pull request as ready for review March 4, 2025 05:22
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as before afaict. There is a small oddity in that the guest avatar color changes depending on whether they are logged in or not whereas normal users (with no loadable icon) the color is fixed and apparently random (not their accent color). Not sure if this is intended.

There is some repeated code for removing color classes.

Conflict resolution required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants