Move preprocessing out of adapters #2312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify execute (and stream) by removing processing argument
fishcakez
commented
Nov 19, 2017
| def query([], _assocs, _sources), do: [] | ||
| def query(rows, [], _sources), do: rows | ||
| def query([], _assocs, _sources, _fun), do: [] | ||
| def query(rows, [], _sources, fun), do: Enum.map(rows, fun) |
There was a problem hiding this comment.
We would be able to delay this map until next step (preloading) to minimize traversals. However if Ecto controls all processing perhaps we can do better.
josevalim
approved these changes
Nov 20, 2017
|
I guess it will be a ring thing to mention @elixir-ecto/adapters here |
|
You're right @AndrewDryga. I also added @ankhers to the team since he took over the maintenance of the mongodb adapter. |
bartekupartek
pushed a commit
to bartekupartek/ecto
that referenced
this pull request
Mar 19, 2019
Simplify execute (and stream) by removing processing argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify execute (and stream) by removing processing argument. This is a breaking change but it is possible to get backwards compatibility from Ecto 2.2 for an adapter by defining a default preprocessing argument as
nilorfn x -> x enddepending on the adapter logic.I am not aware of a noSQL adapter that has supported #2155 and this PR builds on top of that in a way.
This will fix the log entry result for SQL drivers. It would be possible to do this by just changing the SQL adapter.