Add suport for /proc/[pid]/task/[tid]/children #180
Conversation
src/process/task.rs
Outdated
| let (mut child1, mut child2) = (command.spawn().unwrap(), command.spawn().unwrap()); | ||
|
|
||
| // Cargo tests run on multiple threads under the same process by default | ||
| // There doesn't seem to be an easy way to get the current thread ID |
There was a problem hiding this comment.
What about https://docs.rs/rustix/latest/rustix/thread/fn.gettid.html to get the thread ID?
There was a problem hiding this comment.
Good point. Didn't realize rustix has that utility. I'll change it.
|
You can ignore the CI failure (or you can rebase to get a fix for that) |
src/process/task.rs
Outdated
| /// Thread children from `/proc/<pid>/task/<tid>/children` | ||
| /// | ||
| /// This data will be unique per task. |
There was a problem hiding this comment.
I'd love to see these docs expanded a bit. In particular, the procfs(5) man page lists some caveats that look important and I'd like to see them replicated here.
There was a problem hiding this comment.
After looking at the man page, it seems the inclusion of this interface might be more harmful than helpful. Were you intentionally excluding it?
There was a problem hiding this comment.
Nope, I wasn't intentionally excluding it. It didn't look very useful, so I didn't rush to add it myself, but the procfs crate aims to support as much as possible, so I'd like to include this functionality.
I should also note that using |
|
Could you please rebase on top of the latest master branch (instead of merging it into your feature branch)? This will result is a much cleaner history. If you're not sure how to do this, I'd be happy to help explain the steps. |
|
Sorry, I don't have a lot of experience with forked projects. I tried to rebase but clearly it didn't work. What steps should I take to get it in the right state? |
|
Oh, I think I see what might have happened. Correct me if I'm wrong, but I think your successfully rebased, but when you went to push your branch, git told you that it wasn't a fast-forward, and it recommended that you run I hope you don't mind, but I've fixed this for you by force-pushing to your Since I did a force-push, can you quickly skim the commits in this PR to make sure they look OK to you? |
|
That is exactly what happened. Thanks so much for the help! Sorry for the delay, everything looks good. |
While using this library I came across the need to find the children of a process. I saw that it was not supported, but it seemed fairly easy to implement so I took a shot at it.
I'm new to Rust so I welcome any suggestions.