-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: check force push #430
base: main
Are you sure you want to change the base?
Conversation
Example: daixiang0#2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see three changes :
- Do not check when the PR is draft
- Do not fail the workflow even if the force push is detected.
- Instead, put a bot comment on the PR
137028c
to
e123676
Compare
Add a check for force push in CI. Signed-off-by: Loong <[email protected]>
e123676
to
79f0fc1
Compare
Example: daixiang0#3 Skip draft and WIP as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looking good! one last request: would it be possible to delete the previous comment if exists?
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
script: | | ||
const comment = "Force push detected. Please read CONTRIBUTION.md and do not force push unless DCO issue."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const comment = "Force push detected. Please read CONTRIBUTION.md and do not force push unless DCO issue."; | |
const comment = "We’ve detected a force push. Please review the [contribution guidelines](https://github.com/envoyproxy/ai-gateway/blob/main/CONTRIBUTING.md), and avoid force pushing unless you’re addressing a DCO issue after marking your PR as ready for review." |
|
||
on: | ||
pull_request_target: | ||
types: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not that knowledgeable but opened
, edited
and ready_for_review
are necessary? synchrnize seems enough but not sure
Commit Message
Add a check for force push in CI.
Related Issues/PRs (if applicable)
Fixes #429