Skip to content

fix release build #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Nov 6, 2024

Fix the without_v_release_tag release tag.

Tested locally:

➜  gateway git:(fix-release-build) ✗ export  GITHUB_REF=refs/tags/v1.2.0             
➜  gateway git:(fix-release-build) ✗ without_v_release_tag=$(echo ${GITHUB_REF##*/v})
➜  gateway git:(fix-release-build) ✗ echo $without_v_release_tag                     
1.2.0

@zhaohuabing zhaohuabing requested a review from a team as a code owner November 6, 2024 13:59
@zhaohuabing zhaohuabing marked this pull request as draft November 6, 2024 13:59
@zhaohuabing zhaohuabing force-pushed the fix-release-build branch 2 times, most recently from 63e5cfa to 95ed8da Compare November 6, 2024 14:05
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing marked this pull request as ready for review November 6, 2024 14:19
@zhaohuabing zhaohuabing merged commit dd1c66f into envoyproxy:release/v1.2 Nov 6, 2024
6 checks passed
@zhaohuabing zhaohuabing deleted the fix-release-build branch November 6, 2024 14:25
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (0d785e0) to head (148bdbc).
Report is 1 commits behind head on release/v1.2.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.2    #4645      +/-   ##
================================================
- Coverage         65.60%   65.56%   -0.05%     
================================================
  Files               211      211              
  Lines             31942    31942              
================================================
- Hits              20955    20942      -13     
- Misses             9746     9757      +11     
- Partials           1241     1243       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing restored the fix-release-build branch November 7, 2024 01:22
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Nov 7, 2024
Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit dd1c66f)
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing added a commit that referenced this pull request Nov 7, 2024
(cherry picked from commit dd1c66f)

Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants