fix: Allow weights to be zero on endpoints #5278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrien-nydig
force-pushed
the
zero-weight-fix
branch
from
b17d9c6 to
3fa85dd
Compare
|
can you add a test case for this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5278 +/- ##
==========================================
+ Coverage 64.94% 64.97% +0.03%
==========================================
Files 214 214
Lines 33532 33536 +4
==========================================
+ Hits 21776 21789 +13
+ Misses 10412 10404 -8
+ Partials 1344 1343 -1 ☔ View full report in Codecov by Sentry. |
zirain
force-pushed
the
zero-weight-fix
branch
from
3fa85dd to
826d68d
Compare
tobrien-nydig
force-pushed
the
zero-weight-fix
branch
from
943cead to
cef2f8b
Compare
|
@zirain Done |
|
@tobrien-nydig mentioned in #5277 (comment), the change needs to be in the gateway-api layer similar to what's linked in the issue |
tobrien-nydig
force-pushed
the
zero-weight-fix
branch
from
ef97527 to
f51788d
Compare
@zirain I see now (I hope!). I updated the code and put in a proper test case for the weight. |
arkodg
reviewed
Feb 19, 2025
tobrien-nydig
force-pushed
the
zero-weight-fix
branch
2 times, most recently
from
c28a384 to
f7d4b9f
Compare
|
@arkodg updated UDP and added tests |
|
@tobrien-nydig can you fix DCO and force push |
Signed-off-by: Tim OBrien <[email protected]>
* chore: bump go to 1.24 Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]>
…c/kind (envoyproxy#5295) build(deps): bump sigs.k8s.io/kind in /tools/src/kind Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]>
) Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.17.0...v3.17.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]>
…date (envoyproxy#5290) Bumps the golang-org group with 1 update in the / directory: [golang.org/x/net](https://github.com/golang/net). Bumps the golang-org group with 1 update in the /examples/extension-server directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-org - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-org ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]>
…64.5 in /tools/src/golangci-lint (envoyproxy#5294) build(deps): bump github.com/golangci/golangci-lint Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.4 to 1.64.5. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.63.4...v1.64.5) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
…11 (envoyproxy#5293) Bumps [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) from 5.9.0 to 5.9.11. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](evanphx/json-patch@v5.9.0...v5.9.11) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]>
* api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
chore: ignore Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]>
Signed-off-by: Tim OBrien <[email protected]>
tobrien-nydig
force-pushed
the
zero-weight-fix
branch
from
ed2cd5e to
10602e9
Compare
Signed-off-by: tobrien-nydig <[email protected]>
|
@arkodg Ah yeah, done. Sorry not in my normal git workflow :) |
arkodg
approved these changes
Feb 19, 2025
zirain
approved these changes
Feb 19, 2025
|
would be better to have a changelog? |
|
hey @tobrien-nydig last thing needed ( I promise :) ) is a note in the |
|
merging to avoid conflicts, I'll update the release notes seperately |
guydc
added a commit
to guydc/gateway
that referenced
this pull request
Mar 4, 2025
* fix: Allow weights to be zero on endpoints Signed-off-by: Tim OBrien <[email protected]> * chore: bump go to 1.24 (envoyproxy#5287) * chore: bump go to 1.24 Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump sigs.k8s.io/kind from 0.26.0 to 0.27.0 in /tools/src/kind (envoyproxy#5295) build(deps): bump sigs.k8s.io/kind in /tools/src/kind Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump helm.sh/helm/v3 from 3.17.0 to 3.17.1 (envoyproxy#5291) Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.17.0...v3.17.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump the golang-org group across 2 directories with 1 update (envoyproxy#5290) Bumps the golang-org group with 1 update in the / directory: [golang.org/x/net](https://github.com/golang/net). Bumps the golang-org group with 1 update in the /examples/extension-server directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-org - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-org ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/golangci/golangci-lint from 1.63.4 to 1.64.5 in /tools/src/golangci-lint (envoyproxy#5294) build(deps): bump github.com/golangci/golangci-lint Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.4 to 1.64.5. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.63.4...v1.64.5) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * remove Signed-off-by: Tim OBrien <[email protected]> * Found the bug for real Signed-off-by: Tim OBrien <[email protected]> * Focus on gatewayapi Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/evanphx/json-patch/v5 from 5.9.0 to 5.9.11 (envoyproxy#5293) Bumps [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) from 5.9.0 to 5.9.11. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](evanphx/json-patch@v5.9.0...v5.9.11) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * api: BackendTrafficPolicy DNSLookupFamily (envoyproxy#5249) * api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * clean up logic on if Signed-off-by: Tim OBrien <[email protected]> * Update logic and add udp tests Signed-off-by: Tim OBrien <[email protected]> * fix udp tests Signed-off-by: Tim OBrien <[email protected]> * chore: ignore `sched.co` (envoyproxy#5305) chore: ignore Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * newline Signed-off-by: Tim OBrien <[email protected]> --------- Signed-off-by: Tim OBrien <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: tobrien-nydig <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guy Daich <[email protected]> (cherry picked from commit 1f9a1bd) Signed-off-by: Guy Daich <[email protected]>
guydc
added a commit
that referenced
this pull request
Mar 4, 2025
* feat: add defaulter for gateway-api resources loading from file (#5232) * add defaulter that can set default values for our crd Signed-off-by: shawnh2 <[email protected]> * resolve conflicts Signed-off-by: shawnh2 <[email protected]> * add gateway schema defaulter while loading resources and fix all existing tests Signed-off-by: shawnh2 <[email protected]> * add load test for all supported kind resources Signed-off-by: shawnh2 <[email protected]> * fix lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit 7146fe8) Signed-off-by: Guy Daich <[email protected]> * fix: Allow weights to be zero on endpoints (#5278) * fix: Allow weights to be zero on endpoints Signed-off-by: Tim OBrien <[email protected]> * chore: bump go to 1.24 (#5287) * chore: bump go to 1.24 Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump sigs.k8s.io/kind from 0.26.0 to 0.27.0 in /tools/src/kind (#5295) build(deps): bump sigs.k8s.io/kind in /tools/src/kind Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump helm.sh/helm/v3 from 3.17.0 to 3.17.1 (#5291) Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.17.0...v3.17.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump the golang-org group across 2 directories with 1 update (#5290) Bumps the golang-org group with 1 update in the / directory: [golang.org/x/net](https://github.com/golang/net). Bumps the golang-org group with 1 update in the /examples/extension-server directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-org - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-org ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/golangci/golangci-lint from 1.63.4 to 1.64.5 in /tools/src/golangci-lint (#5294) build(deps): bump github.com/golangci/golangci-lint Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.4 to 1.64.5. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.63.4...v1.64.5) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * remove Signed-off-by: Tim OBrien <[email protected]> * Found the bug for real Signed-off-by: Tim OBrien <[email protected]> * Focus on gatewayapi Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/evanphx/json-patch/v5 from 5.9.0 to 5.9.11 (#5293) Bumps [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) from 5.9.0 to 5.9.11. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](evanphx/json-patch@v5.9.0...v5.9.11) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * api: BackendTrafficPolicy DNSLookupFamily (#5249) * api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * clean up logic on if Signed-off-by: Tim OBrien <[email protected]> * Update logic and add udp tests Signed-off-by: Tim OBrien <[email protected]> * fix udp tests Signed-off-by: Tim OBrien <[email protected]> * chore: ignore `sched.co` (#5305) chore: ignore Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * newline Signed-off-by: Tim OBrien <[email protected]> --------- Signed-off-by: Tim OBrien <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: tobrien-nydig <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guy Daich <[email protected]> (cherry picked from commit 1f9a1bd) Signed-off-by: Guy Daich <[email protected]> * fix: Standalone mode - Secret and ConfigMap parsing (#5329) * Added Secret and ConfigMap parsing Signed-off-by: Balazs Stasz <[email protected]> * Updated release notes Signed-off-by: Balazs Stasz <[email protected]> * Fixed lint issues Signed-off-by: Balazs Stasz <[email protected]> * Fixed gen-check issues Signed-off-by: Balazs Stasz <[email protected]> * Added new test cases for Secret Signed-off-by: Balazs Stasz <[email protected]> --------- Signed-off-by: Balazs Stasz <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit a41e992) Signed-off-by: Guy Daich <[email protected]> * fix: backendSettings for extAuth (#5372) * fix: backendSettings for extAuth Fixes: #5371 Signed-off-by: Arko Dasgupta <[email protected]> * release note Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 1c0eca6) Signed-off-by: Guy Daich <[email protected]> * conformance: skip, skip-test features (#5399) So they dont show up in the supportedFeatures section of the conformance report Relates to kubernetes-sigs/gateway-api#3651 (comment) Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit bd53727) Signed-off-by: Guy Daich <[email protected]> * validate all xds resources before returning the translation result (#5148) * validate all xds resources before returning the translation result Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix lint Signed-off-by: Huabing (Robin) Zhao <[email protected]> * Log errors when envoy rejects xDS resources Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove duplicated line Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit b1bf609) Signed-off-by: Guy Daich <[email protected]> * chore: bump go 1.23.6 (#5204) (cherry picked from commit 48459d4) Signed-off-by: Guy Daich <[email protected]> * build(deps): bump the k8s-io group (#5309) * build(deps): bump the k8s-io group across 2 directories with 7 updates Bumps the k8s-io group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.1` | `0.32.2` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.1` | `0.32.2` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.1` | `0.32.2` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.32.1` | `0.32.2` | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.20.1` | `0.20.2` | Bumps the k8s-io group with 2 updates in the /examples/extension-server directory: [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `k8s.io/api` from 0.32.1 to 0.32.2 - [Commits](kubernetes/api@v0.32.1...v0.32.2) Updates `k8s.io/apiextensions-apiserver` from 0.32.1 to 0.32.2 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.32.1...v0.32.2) Updates `k8s.io/apimachinery` from 0.32.1 to 0.32.2 - [Commits](kubernetes/apimachinery@v0.32.1...v0.32.2) Updates `k8s.io/cli-runtime` from 0.32.1 to 0.32.2 - [Commits](kubernetes/cli-runtime@v0.32.1...v0.32.2) Updates `k8s.io/client-go` from 0.32.1 to 0.32.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.1...v0.32.2) Updates `k8s.io/kubectl` from 0.32.1 to 0.32.2 - [Commits](kubernetes/kubectl@v0.32.1...v0.32.2) Updates `sigs.k8s.io/controller-runtime` from 0.20.1 to 0.20.2 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.20.1...v0.20.2) Updates `k8s.io/apimachinery` from 0.32.1 to 0.32.2 - [Commits](kubernetes/apimachinery@v0.32.1...v0.32.2) Updates `sigs.k8s.io/controller-runtime` from 0.20.1 to 0.20.2 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.20.1...v0.20.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <[email protected]> * chore: bump k8s.io Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 3e08722) Signed-off-by: Guy Daich <[email protected]> * chore: fix CVE (#5360) * chore: fix CVE Signed-off-by: zirain <[email protected]> * lint Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit c8f518b) Signed-off-by: Guy Daich <[email protected]> * chore: bump go 1.23.5 (#5190) * chore: bump go Signed-off-by: zirain <[email protected]> * bump controller-gen Signed-off-by: zirain <[email protected]> * 1.23.5 Signed-off-by: zirain <[email protected]> * revert Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit d50be42) Signed-off-by: Guy Daich <[email protected]> * fix dependencies Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: tobrien-nydig <[email protected]> Signed-off-by: Balazs Stasz <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: sh2 <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: tobrien-nydig <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Balazs Stasz <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Mar 5, 2025
* fix: Allow weights to be zero on endpoints Signed-off-by: Tim OBrien <[email protected]> * chore: bump go to 1.24 (envoyproxy#5287) * chore: bump go to 1.24 Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump sigs.k8s.io/kind from 0.26.0 to 0.27.0 in /tools/src/kind (envoyproxy#5295) build(deps): bump sigs.k8s.io/kind in /tools/src/kind Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump helm.sh/helm/v3 from 3.17.0 to 3.17.1 (envoyproxy#5291) Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.17.0...v3.17.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump the golang-org group across 2 directories with 1 update (envoyproxy#5290) Bumps the golang-org group with 1 update in the / directory: [golang.org/x/net](https://github.com/golang/net). Bumps the golang-org group with 1 update in the /examples/extension-server directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-org - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-org ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/golangci/golangci-lint from 1.63.4 to 1.64.5 in /tools/src/golangci-lint (envoyproxy#5294) build(deps): bump github.com/golangci/golangci-lint Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.4 to 1.64.5. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.63.4...v1.64.5) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * remove Signed-off-by: Tim OBrien <[email protected]> * Found the bug for real Signed-off-by: Tim OBrien <[email protected]> * Focus on gatewayapi Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/evanphx/json-patch/v5 from 5.9.0 to 5.9.11 (envoyproxy#5293) Bumps [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) from 5.9.0 to 5.9.11. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](evanphx/json-patch@v5.9.0...v5.9.11) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * api: BackendTrafficPolicy DNSLookupFamily (envoyproxy#5249) * api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * clean up logic on if Signed-off-by: Tim OBrien <[email protected]> * Update logic and add udp tests Signed-off-by: Tim OBrien <[email protected]> * fix udp tests Signed-off-by: Tim OBrien <[email protected]> * chore: ignore `sched.co` (envoyproxy#5305) chore: ignore Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * newline Signed-off-by: Tim OBrien <[email protected]> --------- Signed-off-by: Tim OBrien <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: tobrien-nydig <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guy Daich <[email protected]> (cherry picked from commit 1f9a1bd) Signed-off-by: Huabing (Robin) Zhao <[email protected]>
zhaohuabing
added a commit
that referenced
this pull request
Mar 6, 2025
* validate all xds resources before returning the translation result (#5148) * validate all xds resources before returning the translation result Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit b1bf609) Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: Allow weights to be zero on endpoints (#5278) * fix: Allow weights to be zero on endpoints Signed-off-by: Tim OBrien <[email protected]> * chore: bump go to 1.24 (#5287) * chore: bump go to 1.24 Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump sigs.k8s.io/kind from 0.26.0 to 0.27.0 in /tools/src/kind (#5295) build(deps): bump sigs.k8s.io/kind in /tools/src/kind Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump helm.sh/helm/v3 from 3.17.0 to 3.17.1 (#5291) Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.17.0...v3.17.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump the golang-org group across 2 directories with 1 update (#5290) Bumps the golang-org group with 1 update in the / directory: [golang.org/x/net](https://github.com/golang/net). Bumps the golang-org group with 1 update in the /examples/extension-server directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) Updates `golang.org/x/net` from 0.34.0 to 0.35.0 - [Commits](golang/net@v0.34.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-org - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-org ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/golangci/golangci-lint from 1.63.4 to 1.64.5 in /tools/src/golangci-lint (#5294) build(deps): bump github.com/golangci/golangci-lint Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.4 to 1.64.5. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.63.4...v1.64.5) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * Add test case Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * one more test Signed-off-by: Tim OBrien <[email protected]> * remove Signed-off-by: Tim OBrien <[email protected]> * Found the bug for real Signed-off-by: Tim OBrien <[email protected]> * Focus on gatewayapi Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * cleanup Signed-off-by: Tim OBrien <[email protected]> * build(deps): bump github.com/evanphx/json-patch/v5 from 5.9.0 to 5.9.11 (#5293) Bumps [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) from 5.9.0 to 5.9.11. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](evanphx/json-patch@v5.9.0...v5.9.11) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Tim OBrien <[email protected]> * api: BackendTrafficPolicy DNSLookupFamily (#5249) * api: BackendTrafficPolicy DNSLookupFamily Signed-off-by: Guy Daich <[email protected]> * fix api Signed-off-by: Guy Daich <[email protected]> * fix enum Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * clean up logic on if Signed-off-by: Tim OBrien <[email protected]> * Update logic and add udp tests Signed-off-by: Tim OBrien <[email protected]> * fix udp tests Signed-off-by: Tim OBrien <[email protected]> * chore: ignore `sched.co` (#5305) chore: ignore Signed-off-by: zirain <[email protected]> Signed-off-by: Tim OBrien <[email protected]> * newline Signed-off-by: Tim OBrien <[email protected]> --------- Signed-off-by: Tim OBrien <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: tobrien-nydig <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guy Daich <[email protected]> (cherry picked from commit 1f9a1bd) Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: Standalone mode - Secret and ConfigMap parsing (#5329) * Added Secret and ConfigMap parsing Signed-off-by: Balazs Stasz <[email protected]> * Updated release notes Signed-off-by: Balazs Stasz <[email protected]> * Fixed lint issues Signed-off-by: Balazs Stasz <[email protected]> * Fixed gen-check issues Signed-off-by: Balazs Stasz <[email protected]> * Added new test cases for Secret Signed-off-by: Balazs Stasz <[email protected]> --------- Signed-off-by: Balazs Stasz <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit a41e992) Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: backendSettings for extAuth (#5372) * fix: backendSettings for extAuth Fixes: #5371 Signed-off-by: Arko Dasgupta <[email protected]> * release note Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 1c0eca6) Signed-off-by: Huabing (Robin) Zhao <[email protected]> * bump version to 1.2.7 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix gen Signed-off-by: Huabing (Robin) Zhao <[email protected]> * bump ratelimit to ae4cee11 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix gen Signed-off-by: Huabing (Robin) Zhao <[email protected]> * bump ratelimt Signed-off-by: Huabing (Robin) Zhao <[email protected]> * bump ratelimit Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Tim OBrien <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: tobrien-nydig <[email protected]> Signed-off-by: Balazs Stasz <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: tobrien-nydig <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Balazs Stasz <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: nil pointer exception in udproutes and tcproutes
What this PR does / why we need it:
A nil pointer exception is being thrown when weights are zero in TCPRoutes and UDPRoutes. This fixes the issue by checking if the destination setting is null and adds tests to verify functionality
Which issue(s) this PR fixes:
Fixes #5277
Release Notes: Yes/No