fix: process remaining gatewayClasses after encountering an err #5953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* instead of returning from Reconcile after encountering an err which processing a `GatewayClass`, `continue` instead to process all GatewayClasses Fixes: envoyproxy#5618 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
changed the title
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (22.22%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5953 +/- ##
==========================================
+ Coverage 65.80% 65.89% +0.09%
==========================================
Files 217 217
Lines 36013 36009 -4
==========================================
+ Hits 23699 23729 +30
+ Misses 10834 10806 -28
+ Partials 1480 1474 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
zirain
approved these changes
May 8, 2025
cnvergence
approved these changes
May 8, 2025
|
/retest |
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
May 8, 2025
…yproxy#5953) fix: process all gatewayClasses after encountering an err * instead of returning from Reconcile after encountering an err which processing a `GatewayClass`, `continue` instead to process all GatewayClasses Fixes: envoyproxy#5618 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 64845fe) Signed-off-by: Guy Daich <[email protected]>
guydc
added a commit
that referenced
this pull request
May 8, 2025
* fix: return err if direct response size exceeds limit (#5710) * fix: return err if direct response size exceeds limit Signed-off-by: Arko Dasgupta <[email protected]> * lint Signed-off-by: Arko Dasgupta <[email protected]> * add another check Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 3ebf245) Signed-off-by: Guy Daich <[email protected]> * fix: httproute precedence by considering header/query match type (#5740) * fix precedence to use number of exact matches Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit b295b09) Signed-off-by: Guy Daich <[email protected]> * fix: SecurityPolicy reference grant (#5792) * fix: SecurityPolicy reference grant Signed-off-by: kkk777-7 <[email protected]> * add: release note Signed-off-by: kkk777-7 <[email protected]> * update: func name Signed-off-by: kkk777-7 <[email protected]> * revert func name Signed-off-by: kkk777-7 <[email protected]> * update: use processBackendRef to handle route backends Signed-off-by: kkk777-7 <[email protected]> * fix: use not pointer type for extAuth backendRef Signed-off-by: kkk777-7 <[email protected]> * Add: testcase for ExtAuth Signed-off-by: kkk777-7 <[email protected]> * fix: add jwt backendref to backendSecurityPolicyIndexFunc Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit ef50718) Signed-off-by: Guy Daich <[email protected]> * fix: add validation for header values (#5933) Signed-off-by: Gavin Lam <[email protected]> (cherry picked from commit 5e7df65) Signed-off-by: Guy Daich <[email protected]> * fix: Fixed typo in error message. (#5945) Signed-off-by: Mathias Westby Skoglund <[email protected]> Co-authored-by: Mathias Westby Skoglund <[email protected]> (cherry picked from commit 2bbbdf8) Signed-off-by: Guy Daich <[email protected]> * fix gen Signed-off-by: Guy Daich <[email protected]> * merge fixes Signed-off-by: Guy Daich <[email protected]> * fix: process remaining gatewayClasses after encountering an err (#5953) fix: process all gatewayClasses after encountering an err * instead of returning from Reconcile after encountering an err which processing a `GatewayClass`, `continue` instead to process all GatewayClasses Fixes: #5618 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 64845fe) Signed-off-by: Guy Daich <[email protected]> * fix: do not add tls inspector filter to quic listener (#5671) * fix: enable http3 but panic Signed-off-by: bitliu <[email protected]> (cherry picked from commit 46e053b) Signed-off-by: Guy Daich <[email protected]> * notes Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Gavin Lam <[email protected]> Signed-off-by: Mathias Westby Skoglund <[email protected]> Signed-off-by: bitliu <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: Gavin Lam <[email protected]> Co-authored-by: Mathias Westby Skoglund <[email protected]> Co-authored-by: Mathias Westby Skoglund <[email protected]> Co-authored-by: Xunzhuo <[email protected]>
melsal13
referenced
this pull request
in melsal13/gatewayPersonal
May 9, 2025
fix: process all gatewayClasses after encountering an err * instead of returning from Reconcile after encountering an err which processing a `GatewayClass`, `continue` instead to process all GatewayClasses Fixes: envoyproxy/gateway#5618 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: melsal13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GatewayClass,continueinstead to process all GatewayClassesFixes: #5618