Expose Config structures outside package #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arkodg I tried re-running and I'm not sure if the DNS failure is spurious or the test points somewhere that no longer exists. Can you take a look when you have time? |
|
@mattklein123 raised #375 to fix the test failure |
* Allow downstream projects to reuse the config structure and generate the rate limit service config programatically w/o creating their own custom structures. Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
force-pushed
the
expose-rl-config
branch
from
50e6148 to
2d8ea50
Compare
barroca
pushed a commit
to barroca/ratelimit
that referenced
this pull request
Sep 1, 2023
* Allow downstream projects to reuse the config structure and generate the rate limit service config programatically w/o creating their own custom structures. Signed-off-by: Arko Dasgupta <[email protected]>
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
* Allow downstream projects to reuse the config structure and generate the rate limit service config programatically w/o creating their own custom structures. Signed-off-by: Arko Dasgupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arko Dasgupta [email protected]