Add new forward model configuration style #10597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10597 will not alter performanceComparing Summary
Benchmarks breakdown
|
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
4 times, most recently
from
d436308 to
c08e84f
Compare
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
2 times, most recently
from
f4edd63 to
7ccd960
Compare
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
11 times, most recently
from
2e08023 to
3d84617
Compare
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
from
3943605 to
bfae075
Compare
oyvindeide
reviewed
Apr 22, 2025
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
2 times, most recently
from
cee48fb to
50275f0
Compare
oyvindeide
reviewed
Apr 29, 2025
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
from
a182c95 to
7ef2639
Compare
oyvindeide
reviewed
Apr 29, 2025
oyvindeide
reviewed
Apr 29, 2025
oyvindeide
reviewed
Apr 29, 2025
oyvindeide
reviewed
Apr 29, 2025
oyvindeide
reviewed
Apr 29, 2025
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
7 times, most recently
from
0af90ee to
93aaabf
Compare
oyvindeide
reviewed
May 2, 2025
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
from
93aaabf to
f56d2ab
Compare
oyvindeide
approved these changes
May 7, 2025
src/everest/config/everest_config.py
Outdated
| @classmethod | ||
| def validate_no_data_file(cls, values: dict[str, Any]) -> dict[str, Any]: | ||
| data_file = values.get("model", {}).get("data_file", None) | ||
| eclbase = values.get("definitions", {}).get("eclbase", None) |
There was a problem hiding this comment.
Should have a different default than None here, so that the text below makes more sense, for example: <name_of_smspec>
tests/everest/test_egg_simulation.py
Outdated
| @@ -575,7 +575,7 @@ def test_opm_fail_default_summary_keys(copy_egg_test_data_to_tmp): | |||
|
|
|||
| config = EverestConfig.load_file(CONFIG_FILE) | |||
| # The Everest config file will fail to load as an Eclipse data file | |||
| config.model.data_file = os.path.realpath(CONFIG_FILE) | |||
| # config.model.data_file = os.path.realpath(CONFIG_FILE) | |||
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
from
f56d2ab to
6817af9
Compare
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
from
6817af9 to
e6b154d
Compare
yngve-sk
force-pushed
the
25.04.10.everest-fm-config-change
branch
from
e6b154d to
43dcba2
Compare
yngve-sk
added
the
release-notes:new-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to specify results per forward model in Everest, as well as saving GEN_DATA (that is not necessarily a constraint or objective) from forward model runs
Issue
Resolves #9615